Skip to content

major refactoring of PLFQ to a probabilistic approach#300

Merged
ypriverol merged 8 commits intobigbio:devfrom
ypriverol:dev
Oct 12, 2023
Merged

major refactoring of PLFQ to a probabilistic approach#300
ypriverol merged 8 commits intobigbio:devfrom
ypriverol:dev

Conversation

@ypriverol
Copy link
Member

@ypriverol ypriverol commented Oct 5, 2023 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ypriverol ypriverol requested a review from jpfeuffer October 5, 2023 13:15
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit c1b5874

+| ✅ 156 tests passed       |+
#| ❔   4 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-11 12:59:46

@timosachsenberg
Copy link

timosachsenberg commented Oct 8, 2023

FYI I added the possibility to also filter by probabilistic score if targeted_only is true. Then only the feature_with_id* parameter is used.

jpfeuffer
jpfeuffer reviewed Oct 9, 2023
View reviewed changes
ypriverol and others added 2 commits October 9, 2023 21:56
@ypriverol @jpfeuffer
Update modules/local/openms/proteomicslfq/main.nf
3cbfecb 
Co-authored-by: Julianus Pfeuffer <julianus.pfeuffer@pfizer.com>
@ypriverol
Update filters nextflow.config
c1b5874 
based on comment #301 (comment) and the corresponding benchamrks I have updated the filters and parameters for LFQ
@ypriverol ypriverol merged commit 982d2e3 into bigbio:dev Oct 12, 2023
@ypriverol ypriverol mentioned this pull request Oct 13, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpfeuffer jpfeuffer jpfeuffer left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ypriverol @timosachsenberg @jpfeuffer