Skip to content

Conversation

@haslinghuis
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis
Copy link
Member Author

504:

image

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving. tested UI and video-export successfully.

@haslinghuis haslinghuis merged commit 335a529 into betaflight:master Jan 17, 2024
@haslinghuis haslinghuis deleted the update-nwjs-ffmpeg branch January 17, 2024 20:18
@ctzsnooze
Copy link
Member

ctzsnooze commented Jan 18, 2024

@haslinghuis @nerdCopter Unfortunately this has broken compatibility with Mac OSX 10.14, the compiled binary simply will not run.

MacOSX14 is quite old but is one of the last versions that still runs intel-only binaries, and some of those programs cannot easily be found in newer MacOSX versions.

Could we revert this change for Mac OSX? Is it absolutely essential?

I can't find information about the version where support for below 10.15 was removed.

@nerdCopter
Copy link
Member

nerdCopter commented Jan 18, 2024

https://dev.to/thejaredwilcurt/guide-to-nw-js-versions-5d38

0.72.0 was no longer downloading during github actions, therefore this PR was made.
reverting will again break github actions, unless the problem is fixed outside of betaflight control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants