Skip to content

support firmware rpm filter name changes, minor cleanups #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ctzsnooze wants to merge 2 commits into from
Closed

support firmware rpm filter name changes, minor cleanups #532

ctzsnooze wants to merge 2 commits into from

Conversation

@ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Sep 17, 2021

Changes:

  • Supports the rpm filteringname changes from 10856.
  • Includes rpm_filter_fade_range_hz parameter
  • Tidies up the gyro lowpass filtering html
  • Moves DShot min and max values to the Motors section, leaving idle values in the Throttle section.
  • Updates comments in flightlog_parser.js about adding new parameters
  • Whitespace tidy ups

Image showing rpm_filter_fade_range element:

Screen Shot 2021-09-17 at 17 31 57

Image showing the motor and throttle rearrangement
Screen Shot 2021-09-17 at 17 22 23
:

@ctzsnooze ctzsnooze mentioned this pull request Sep 17, 2021
Merged
haslinghuis
haslinghuis requested changes Sep 17, 2021
View reviewed changes
js/header_dialog.js Outdated
setParameter('dterm_rpm_notch_harmonics', sysConfig.dterm_rpm_notch_harmonics, 0);
setParameter('dterm_rpm_notch_q' , sysConfig.dterm_rpm_notch_q , 0);
setParameter('dterm_rpm_notch_min' , sysConfig.dterm_rpm_notch_min , 0);
setParameter('dynNotchQ' ,sysConfig.dyn_notch_q,0);
Copy link
Member

@haslinghuis haslinghuis Sep 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma space please (everywhere)

Copy link
Member Author

@ctzsnooze ctzsnooze Sep 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's 'hit and miss' throughout the document, most lines are ,0); and some are 0);.
I can make them consistent but it will change hundreds of lines :-)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Sep 19, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions
Copy link

github-actions bot commented Oct 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Pull request closed automatically as inactive.

@github-actions github-actions bot closed this Oct 27, 2021
@haslinghuis haslinghuis reopened this Nov 26, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 100 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze
Copy link
Member Author

ctzsnooze commented Nov 26, 2021

Closing since these changes were included in #539, merged recently

@ctzsnooze ctzsnooze closed this Nov 26, 2021
@ctzsnooze ctzsnooze deleted the support-new-rpm-filter-names branch December 28, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@mikeller mikeller Awaiting requested review from mikeller

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@asizon asizon Awaiting requested review from asizon

Assignees

No one assigned

Labels

Inactive Tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctzsnooze @blckmn @haslinghuis