Skip to content

Add motor poles support #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blckmn merged 2 commits into from
Sep 3, 2021
Merged

Add motor poles support #526

blckmn merged 2 commits into from
Sep 3, 2021

Conversation

@atomgomba
Copy link
Contributor

@atomgomba atomgomba commented Aug 13, 2021

Display motor_poles header and convert eRPM's to RPM's when showing DSHOT telemetry graph using this formula:

eRPM * 50 / motorPoleCount

@atomgomba atomgomba force-pushed the feature/motor-poles-support branch from 2ae5c4e to cc4aa95 Compare August 13, 2021 06:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@atomgomba atomgomba mentioned this pull request Aug 13, 2021
Merged
ctzsnooze
ctzsnooze approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the firmware is approved lets merge this.

@haslinghuis haslinghuis added this to the 3.6.0 milestone Sep 1, 2021
@blckmn
Copy link
Member

blckmn commented Sep 3, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@blckmn blckmn self-assigned this Sep 3, 2021
@blckmn blckmn merged commit 683789f into betaflight:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@blckmn blckmn

Labels

RN: IMPROVEMENT

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@atomgomba @blckmn @McGiverGim @haslinghuis @ctzsnooze