Skip to content

Fix rounding in setpoint vs error graph #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctzsnooze merged 1 commit into from
Sep 3, 2021
Merged

Fix rounding in setpoint vs error graph #515

ctzsnooze merged 1 commit into from
Sep 3, 2021

Conversation

@McGiverGim
Copy link
Member

@McGiverGim McGiverGim commented Jun 2, 2021

Fixes #507

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

haslinghuis
haslinghuis approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ctzsnooze
ctzsnooze reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should be more accurate

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@github-actions github-actions bot removed the Inactive label Jul 10, 2021
@njdro
Copy link

njdro commented Jul 15, 2021

git checkout mcgivergim/fix_data_setpoint_graph_rounding

maybe something else needed s well ?
2021-07-15_09-14

ctzsnooze
ctzsnooze approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@haslinghuis haslinghuis added this to the 3.6.0 milestone Aug 31, 2021
@blckmn
Copy link
Member

blckmn commented Sep 3, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze ctzsnooze removed the pinned label Sep 3, 2021
@ctzsnooze ctzsnooze merged commit edcfa3d into betaflight:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@McGiverGim McGiverGim

Labels

RN: BUGFIX Tested

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

Error vs Setpoint zoom/range wierd

5 participants

@McGiverGim @njdro @blckmn @haslinghuis @ctzsnooze