Skip to content

Conversation

@chmelevskij
Copy link
Member

This is matching PR to use node 14 similar to how it's done in configurator. This also adds .nvmrc and engines to match the configurator.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested if video playback is working with the new node version? This is often the sticky point for version compatibility with blackbox explorer, as external codecs are used.

@mikeller mikeller added this to the 3.6.0 milestone Feb 7, 2021
@McGiverGim
Copy link
Member

I've tested it under Windows and it seems video playback works. I'm not totally sure because it is not too smooth but I think this happens too with older version.

@haslinghuis
Copy link
Member

@chmelevskij please rebase. I think this should be merged soon to be in sync with configurator.

@ctzsnooze
Copy link
Member

@chmelevskij it would be great to action this - any chance you could review the conflicts and re-check it is OK?

@chmelevskij
Copy link
Member Author

Hey, will try over the weekend. Want ot match the setup with configurator first.

@chmelevskij
Copy link
Member Author

Updated with changes from configurator still need to verify the builds though.

@haslinghuis
Copy link
Member

@chmelevskij it's not building. Any update on this?

ctzsnooze
ctzsnooze previously approved these changes Jan 29, 2022
@haslinghuis
Copy link
Member

haslinghuis commented Jan 29, 2022

@chmelevskij seems some commits don't belong here?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blckmn
Copy link
Member

blckmn commented Jan 30, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit ba7470b into betaflight:master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants