Fix axisError calculation #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error data should be error = setpoint - gyroadc
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
🤕 Why did those checks fail? |
Contributor
Author
|
Anyway, only the Build Windows succeeded, now the two traces seems correct now. Error and P share the same sign, as they should. |
mikeller
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sign of the axisError[axis] is reversed.
Error data should be :
error = setpoint - gyroADCThe image showed this issue.
error = setpoint - gyroADC, and a plot shows how it looks like.And it seems that the two pieces of error data have different signs.
I can share this script (Jupyter notebook) if you need.