Refactor Spectrum Graph code #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide into two files. One for maths and control, the other for plot
mikeller
approved these changes
Apr 28, 2019
This was referenced Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second of a serie of PR to refactor and give more functionality to the Spectrum Graph (the first was #290).
This second PR only makes a refactor of the file, dividing it into two: one for the Maths and the Control of the actions of the page, the other for the Plot.
I have not changed the way all it works, I simply divided long code into different files and functions. It can be divided more but I think that for this PR is enough as is to not complicate more the review.