Skip to content

TPA clarification - % and μs #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

TPA clarification - % and μs #3846

merged 1 commit into from
Mar 21, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Mar 20, 2024 •
edited
Loading

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 20, 2024
@haslinghuis haslinghuis merged commit 3dff819 into betaflight:master Mar 21, 2024
@ChrisRosser
Copy link
Contributor

Incoming pedantry. 🤣

0.65 is not a % value. We need to multiply the number by 100 as well.
I'm not sure us makes this more understandable. If one is using Dshot then the breakpoint is not a microsecond value at all but rather a value between 0 and 2000 I think.

@nerdCopter
Copy link
Member Author

@haslinghuis , should we revert Configurator? i'm fine with such.

correct, but humans will read 0.65 as 65% quite easily. pardon any break-point mishaps ☹️

@haslinghuis
Copy link
Member

tpa breakpoint is a pwm value between 750 and 2250
tpa_rate is between 0 and 1

Take 2: #3851 😃

@HThuren
Copy link
Member

HThuren commented Mar 21, 2024

in fact a good change

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@nerdCopter @chmelevskij
TPA clarification - % and μs (betaflight#3846)
4dd0c1b
@nerdCopter nerdCopter deleted the 20240320_TPA_language branch October 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@HThuren HThuren HThuren approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@asizon asizon Awaiting requested review from asizon

Assignees

@nerdCopter nerdCopter

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

Change TPA rate and Breakpoint to Percentages for ease of understanding
4 participants
@nerdCopter @ChrisRosser @haslinghuis @HThuren