Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 1, 2024

Fixes

  • getContext error on Windows [10]. This issue did not expose itself on Linux.
  • deprecated use of name variable.
  • only use throttle draw interval on rates tab - improving performance on pid and filter sub tabs - which caused the issue on Windows.

image

EDIT: For reference if want to dive in deeper: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 1, 2024
@haslinghuis haslinghuis self-assigned this Mar 1, 2024

This comment has been minimized.

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving untested

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 3506222 into betaflight:master Mar 2, 2024
@haslinghuis haslinghuis deleted the fix-getcontext branch March 2, 2024 21:05
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants