Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 30, 2023

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 30, 2023
@haslinghuis haslinghuis self-assigned this Dec 30, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis mentioned this pull request Dec 30, 2023
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

Before merging see this with yarn && yarn dev (also on master - and with Android fix in place don't see the error anymore)

Error: The following dependencies are imported but could not be resolved:

  nw.gui (imported by /home/mark/dev/pr/configurator/fix-vite-globals/betaflight-configurator/src/js/gui.js)

Are they installed?
    at file:///home/mark/dev/pr/configurator/fix-vite-globals/betaflight-configurator/node_modules/vite/dist/node/chunks/dep-063880ad.js:45768:23
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///home/mark/dev/pr/configurator/fix-vite-globals/betaflight-configurator/node_modules/vite/dist/node/chunks/dep-063880ad.js:45176:38
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@blckmn
Copy link
Member

blckmn commented Dec 30, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

Copy link
Member

@chmelevskij chmelevskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t fix it. I’ve seen this with @limonspb recently. Will create pr with proper fix

@haslinghuis haslinghuis mentioned this pull request Dec 31, 2023
@haslinghuis
Copy link
Member Author

Closing in favor of #3716

@haslinghuis haslinghuis deleted the fix-vite-globals branch December 31, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants