Skip to content

Conversation

atomgomba
Copy link
Contributor

Fixes #3458. Currently the UI for changing GPS Rescue settings is only enabled if the failsafe stage 2 is configured as GPS Rescue. Because the GPSR settings can be changed at anytime using the CLI, it makes sense to enable the UI also if GPSR is enabled as a mode to make things easier for users.

@atomgomba atomgomba changed the title Enabled GPS Rescue UI if used as a mode Enable GPS Rescue UI if used as a mode Oct 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 18, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested

@haslinghuis haslinghuis merged commit eed226f into betaflight:master Nov 2, 2023
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Enabled GPS Rescue UI if used as a mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

Enable GPS rescue settings when GPS rescue is not selected as stage2 failsafe
4 participants