Skip to content

Conversation

haslinghuis
Copy link
Member

As requested by @limonspb

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 5, 2023
@haslinghuis haslinghuis self-assigned this Jun 5, 2023
@github-actions

This comment has been minimized.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@limonspb
Copy link
Member

limonspb commented Jun 5, 2023

As requested by @limonspb

i see its not a complete revert of the initial PR, why is that?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member Author

haslinghuis commented Jun 5, 2023

i see its not a complete revert of the initial PR, why is that?

  • This only reverts the use of select2.
  • Sort has been improved in the mean time - so using that.
  • Also don't you like the added feature:

image

@limonspb
Copy link
Member

limonspb commented Jun 5, 2023

i see its not a complete revert of the initial PR, why is that?

  • This only reverts the use of select2.
  • Sort has been improved in the mean time - so using that.
  • Also don't you like the added feature:

image

Yeah all good as long as debug mode allows typing in :) thanks sir

@blckmn
Copy link
Member

blckmn commented Jun 6, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis requested a review from nerdCopter June 6, 2023 20:34
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good on one FC

@haslinghuis haslinghuis merged commit 655fb93 into betaflight:master Jun 6, 2023
@haslinghuis haslinghuis deleted the use-select2 branch June 6, 2023 21:06
@HThuren
Copy link
Member

HThuren commented Jun 7, 2023

@haslinghuis , looks good. What is the differenece between multiple_select and select2 ?

@haslinghuis
Copy link
Member Author

select2 adds a search box afaik but it's just a different implementation:

https://multiple-select.wenzhixin.net.cn/
https://select2.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

6 participants