Skip to content

Added autofocus on Select2 elements with a textbox #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Added autofocus on Select2 elements with a textbox #3299

merged 2 commits into from
Feb 1, 2023

Conversation

VitroidFPV
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 31, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Feb 1, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

haslinghuis
haslinghuis reviewed Feb 1, 2023
View reviewed changes
haslinghuis
haslinghuis reviewed Feb 1, 2023
View reviewed changes
haslinghuis
haslinghuis reviewed Feb 1, 2023
View reviewed changes
@VitroidFPV @haslinghuis
Apply suggestions from code review
e2cf620 
Co-authored-by: Mark Haslinghuis <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nerdCopter
nerdCopter approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good

@haslinghuis haslinghuis merged commit fc6bcc2 into betaflight:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@VitroidFPV VitroidFPV

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@VitroidFPV @blckmn @haslinghuis @nerdCopter