Hotfix OSD Drag\Drop for multiline elements

[frozenskys]

Fixes #1159
Please test...

[mikeller]

Looks good except for the stray spaces.

[mikeller]

Stray space.

[mikeller]

Space.

[frozenskys]

You'd think I'd know better having developed python for several years!

[mikeller]

Hmm, this improves it, but I am not sure that it is completely the way it should be. When grabbing a large element on a side, the element will jump to be centered around the mouse cursor once the grabbing has completed, which is unintuitive:

out-3.ogv.zip

I think that instead of this, the mouse cursor should stay on whatever position on the element it is on when the element is grabbed.

[frozenskys]

@mikeller I thought I'd fixed that - are you using the standalone or chrome app - and what OS?

Basically most of the code in onDragStart is working out the pixel offset so this doesn't happen. I'm using the standalone app on Windows 10 64Bit and it's working OK, I'm assuming this is an OS difference.

  onDragStart: function(e) {
    var ev = e.originalEvent;
    var display_item = OSD.data.display_items[$(ev.target).data('field').index];
    var xPos = ev.currentTarget.dataset.x;
    var yPos = ev.currentTarget.dataset.y;
    var offsetX = 6;
    var offsetY = 9;

    if (display_item.preview.constructor === Array) {
        var arrayElements = display_item.preview;
        var limits = OSD.searchLimitsElement(arrayElements);
        xPos -= limits.minX;
        yPos -= limits.minY;
        offsetX += (xPos) * 12;
        offsetY += (yPos) * 18;
    }
    ev.dataTransfer.setDragImage($(this).data('field').preview_img, offsetX, offsetY);
  },

[mikeller]

Tried another time, to check if there was console output. This time it worked fine. No idea what was wrong the last time, but it's all good now, thanks!