refactor: remove python 2 new-style classes as only python 3.5+ is supported now #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
added
the
Code related changes
Closed
Contributor
|
Updated version, with commits split for different cleanup: master...pajod:gunicorn:patch-py36 No harm in merge conflicts, can always be trivially regenerated thanks to https://pypi.org/project/pyupgrade/ Note: This PR contains zero effective changes now (which is OK & expected, after equivalent #3189 was merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2, there were different ways to create classes: the old and new style.
gunicornuses the new-style of class creation, which inherits fromobject. This difference is described here:https://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes
https://www.python.org/download/releases/2.2.3/descrintro/
As
gunicornsupports Python 3.5+ at this time, the use of new-style classes can be removed as all classes in Python 3 are new-style classes by default.