Error in OSGi Manfiest v2.0.0

[nedtwigg]

The manifest contains an error in the Import-package statement.

What it is    : Import-Package: sun.misc,resolution:=optional
What should be: Import-Package: sun.misc;resolution:=optional

note the comma vs semicolon. It currently requires sun.misc, and optionally requests the default package, and OSGi blows up over it. I'd submit a PR, but I couldn't figure out where the manifest was getting generated.

[ben-manes]

Its generated via the Gradle build file.

Do you have any recommendations for how to test OSGi? I've never used it and I seem to screw up the manifest in every release. Is PaxExam the right approach for compatibility testing?

[ben-manes]

I was partially successful and need your help to debug. I added a JUnit sanity test in the caffeine and guava modules, due to the TestNG integration eagerly initializing the container even if the test is skipped (broke tests). The caffeine sanity test passes after your fix.

The guava test fails with the exception below. The class should be exported and the manifest looks correct to me. Can you take a look at the osgi branch?

You can run using gradlew :guava:test.

com.github.benmanes.caffeine.guava.OSGiTest > sanity FAILED
    java.lang.ClassNotFoundException: com.github.benmanes.caffeine.guava.CaffeinatedGuava not found by PAXEXAM-PROBE-bee238e9-41a5-4071-8e3e-776f37fe25be [16]
        at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1574)
        at org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:79)
        at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2018)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at com.github.benmanes.caffeine.guava.OSGiTest.sanity(OSGiTest.java:59)

[nedtwigg]

I'll take a look. I can see the problem in your build.gradle now, but I don't know much about unit-testing OSGi (I do all unit testing as plain-jane Java, and OSGi problems get rattled out in final integration tests). I'll check out your branch and take a look.

Great work, btw, big fan of the library 👍

[ben-manes]

got it!

The error is due to using Guava 18.0 in test's mavenBundle, while the build uses 19.0-rc2. This caused the resolution to fail with a misleading error message. The reason why they differed is because I accidentally set the version to the full artifact coordinate, which it said wasn't on maven central, so I hard coded it to an earlier version. Fixing the system property and it passes. I guess I'm tired :)

I'll try to finish the integration tests tomorrow and cut a patch release.

[nedtwigg]

Good find, I was stuck! I've got a workaround, so no rush on my account.

[ben-manes]

Any chance you're familiar with OSGi + ServiceLoaders? I tried adding the instructions described here, but no luck so far. Probably because tests are consumers and I'm not declaring that right.

com.github.benmanes.caffeine.jcache.OSGiTest > sanity FAILED
    java.util.ServiceConfigurationError: javax.cache.spi.CachingProvider: Provider com.github.benmanes.caffeine.jcache.spi.CaffeineCachingProvider not a subtype
        at java.util.ServiceLoader.fail(ServiceLoader.java:239)
        at java.util.ServiceLoader.access$300(ServiceLoader.java:185)
        at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:376)
        at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
        at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
        at javax.cache.Caching$CachingProviderRegistry$1.run(Caching.java:438)
        at javax.cache.Caching$CachingProviderRegistry$1.run(Caching.java:432)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.cache.Caching$CachingProviderRegistry.getCachingProviders(Caching.java:432)
        at javax.cache.Caching$CachingProviderRegistry.getCachingProvider(Caching.java:370)
        at javax.cache.Caching$CachingProviderRegistry.getCachingProvider(Caching.java:351)
        at javax.cache.Caching.getCachingProvider(Caching.java:142)
        at javax.cache.Caching.getCache(Caching.java:279)
        at com.github.benmanes.caffeine.jcache.OSGiTest.sanity(OSGiTest.java:54)

[nedtwigg]

I can't find com.github.benmanes.caffeine.jcache.OSGiTest. Maybe you need to push your latest to osgi?

[ben-manes]

Did you pull from upstream? Its pushed

[nedtwigg]

Aha! My bad.

[ben-manes]

This might also be due to JCache #326 or at least be a future blocker.

[nedtwigg]

Sorry, I've got no clue.

[ben-manes]

Thanks for trying. It looks like Ehcache3's tests bypass the service loader so I'll try that tonight. I gave it a quick shot and it reported another not found error, so at least its a path to debug down.

[ben-manes]

It turns out that the underling error message goes to standard error, which is available as a separate tab in the html report. The problem is due jsr107 not exporting its packages, as noted in the bug report.

org.osgi.framework.BundleException: Unable to resolve com.github.ben-manes.caffeine.jcache [17](R 17.0): missing requirement [com.github.ben-manes.caffeine.jcache [17](R 17.0)] osgi.wiring.package; (osgi.wiring.package=javax.cache.configuration) Unresolved requirements: [[com.github.ben-manes.caffeine.jcache [17](R 17.0)] osgi.wiring.package; (osgi.wiring.package=javax.cache.configuration)]
    at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4111)
    at org.apache.felix.framework.Felix.startBundle(Felix.java:2117)
    at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1371)
    at org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
    at java.lang.Thread.run(Thread.java:745)