remove unnecessary @CanIgnoreReturnValue usages for stricter checking

Author: ben-manes

caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java

@@ -260,7 +260,6 @@ final class AsyncBulkCompleter<K, V> implements BiFunction<
       throw new CompletionException(failure);
     }
 
-    @CanIgnoreReturnValue
     public CompletionException error(Throwable error) {
       long loadTime = cache.statsTicker().read() - startTime;
       var failure = handleResponse(/* result= */ null, error);

jcache/src/main/java/com/github/benmanes/caffeine/jcache/CacheProxy.java

@@ -444,7 +444,6 @@ public void putAll(Map<? extends K, ? extends V> map) {
   }
 
   @Override
-  @CanIgnoreReturnValue
   public boolean putIfAbsent(K key, V value) {
     requireNotClosed();
     requireNonNull(value);
@@ -509,7 +508,6 @@ private boolean putIfAbsentNoAwait(K key, V value, boolean publishToWriter) {
   }
 
   @Override
-  @CanIgnoreReturnValue
   public boolean remove(K key) {
     requireNotClosed();
     requireNonNull(key);
@@ -622,7 +620,6 @@ public V getAndRemove(K key) {
   }
 
   @Override
-  @CanIgnoreReturnValue
   public boolean replace(K key, V oldValue, V newValue) {
     requireNotClosed();
     requireNonNull(oldValue);
@@ -675,7 +672,6 @@ public boolean replace(K key, V oldValue, V newValue) {
   }
 
   @Override
-  @CanIgnoreReturnValue
   public boolean replace(K key, V value) {
     requireNotClosed();
     boolean statsEnabled = statistics.isEnabled();

jcache/src/test/java/com/github/benmanes/caffeine/jcache/expiry/JCacheCombinedExpiryTest.java

@@ -109,7 +109,7 @@ public void put_expired() {
 
   @Test
   public void putIfAbsent_expired() {
-    jcache.putIfAbsent(KEY_1, VALUE_1);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_1)).isTrue();
     advancePastExpiry();
 
     assertThat(jcache.putIfAbsent(KEY_1, VALUE_2)).isTrue();

jcache/src/test/java/com/github/benmanes/caffeine/jcache/expiry/JCacheCreationExpiryTest.java

@@ -245,7 +245,7 @@ public void putAll_present() {
 
   @Test
   public void putIfAbsent_absent() {
-    jcache.putIfAbsent(KEY_1, VALUE_1);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_1)).isTrue();
 
     Expirable<Integer> expirable = getExpirable(jcache, KEY_1);
     assertThat(expirable).isNotNull();
@@ -255,7 +255,7 @@ public void putIfAbsent_absent() {
 
   @Test
   public void putIfAbsent_expired() {
-    jcache.putIfAbsent(KEY_1, VALUE_1);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_1)).isTrue();
     advancePastExpiry();
 
     assertThat(jcache.putIfAbsent(KEY_1, VALUE_2)).isTrue();
@@ -268,18 +268,18 @@ public void putIfAbsent_expired() {
 
   @Test
   public void putIfAbsent_expired_lazy() {
-    jcache.putIfAbsent(KEY_1, VALUE_1);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_1)).isTrue();
 
     ticker.setAutoIncrementStep(EXPIRY_DURATION.dividedBy(2));
     assertThat(jcache.putIfAbsent(KEY_1, VALUE_2)).isTrue();
   }
 
   @Test
   public void putIfAbsent_present() {
-    jcache.putIfAbsent(KEY_1, VALUE_1);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_1)).isTrue();
     advanceHalfExpiry();
 
-    jcache.putIfAbsent(KEY_1, VALUE_2);
+    assertThat(jcache.putIfAbsent(KEY_1, VALUE_2)).isFalse();
     Expirable<Integer> expirable = getExpirable(jcache, KEY_1);
     assertThat(expirable).isNotNull();
     assertThat(expirable.getExpireTimeMillis())

jcache/src/test/java/com/github/benmanes/caffeine/jcache/expiry/JCacheUpdateExpiryTest.java

@@ -110,8 +110,8 @@ public void put() {
     jcache.put(KEY_1, VALUE_2);
     Expirable<Integer> expirable = getExpirable(jcache, KEY_1);
     assertThat(expirable).isNotNull();
-    assertThat(expirable.getExpireTimeMillis()
-            ).isEqualTo(currentTime().plus(EXPIRY_DURATION).toMillis());
+    assertThat(expirable.getExpireTimeMillis())
+        .isEqualTo(currentTime().plus(EXPIRY_DURATION).toMillis());
   }
 
   @Test
@@ -133,7 +133,7 @@ public void replace() {
     jcache.put(KEY_1, VALUE_1);
     advanceHalfExpiry();
 
-    jcache.replace(KEY_1, VALUE_2);
+    assertThat(jcache.replace(KEY_1, VALUE_2)).isTrue();
     Expirable<Integer> expirable = getExpirable(jcache, KEY_1);
     assertThat(expirable).isNotNull();
     assertThat(expirable.getExpireTimeMillis())