remove unreachable code

Author: ben-manes

.github/actions/spelling/expect.txt

@@ -90,6 +90,7 @@ githubsecuritylab
 gitleaks
 glcache
 gli
+gnubin
 Gnuplot
 Godot
 GPG
@@ -280,6 +281,7 @@ unconfigured
 unhash
 Uninterruptibles
 Unregisters
+usr
 untreeified
 untreeify
 untreeifying

caffeine/src/jcstress/java/com/github/benmanes/caffeine/cache/IntermittentNull.java

@@ -31,7 +31,7 @@
 /**
  * A stress test that simulates the behavior for {@link java.lang.ref.Reference} reads and writes in
  * weak or soft valued caches. The {@link Node#setValue} proactively clears the underlying referent
- * after updating the entry's value. This is done to assist cross-generational pollution which can
+ * after updating the entry's value. This is done to avoid cross-generational pollution which can
  * cause garbage collectors to unnecessarily promote young dead objects to an old collection and
  * increase pause times. The {@link Node#getValue} compensates by a re-check validation to determine
  * if the observed null referent is due to garbage collection or a stale read. Due to referent being

caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java

@@ -146,8 +146,7 @@ default CompletableFuture<Map<K, V>> getAll(Iterable<? extends K> keys,
           Collections.unmodifiableSet(proxies.keySet()), cache().executor());
       return loader.handle(completer).thenCompose(ignored -> composeResult(futures));
     } catch (Throwable t) {
-      completer.apply(/* result= */ null, t);
-      throw t;
+      throw completer.error(t);
     }
   }
 
@@ -261,6 +260,19 @@ final class AsyncBulkCompleter<K, V> implements BiFunction<
       throw new CompletionException(failure);
     }
 
+    @CanIgnoreReturnValue
+    public CompletionException error(Throwable error) {
+      long loadTime = cache.statsTicker().read() - startTime;
+      var failure = handleResponse(/* result= */ null, error);
+      cache.statsCounter().recordLoadFailure(loadTime);
+      if (failure instanceof RuntimeException) {
+        throw (RuntimeException) failure;
+      } else if (failure instanceof Error) {
+        throw (Error) failure;
+      }
+      return new CompletionException(failure);
+    }
+
     private @Nullable Throwable handleResponse(
         @Nullable Map<? extends K, ? extends V> result, @Nullable Throwable error) {
       if (result == null) {

caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncLoadingCache.java

@@ -291,11 +291,7 @@ public CompletableFuture<Map<K, V>> refreshAll(Iterable<? extends K> keys) {
             var value = asyncCache.cache().compute(key, (ignored, currentValue) -> {
               var successful = asyncCache.cache().refreshes().remove(keyReference, castedFuture);
               if (successful && (currentValue == oldValueFuture[0])) {
-                if (currentValue == null) {
-                  // If absent then discard the refresh and maybe notifying the listener
-                  discard[0] = (newValue != null);
-                  return null;
-                } else if ((currentValue == newValue) || (currentValue == castedFuture)) {
+                if ((currentValue == newValue) || (currentValue == castedFuture)) {
                   // If the reloaded value is the same instance then no-op
                   return currentValue;
                 } else if (newValue == Async.getIfReady((CompletableFuture<?>) currentValue)) {

caffeine/src/test/java/com/github/benmanes/caffeine/cache/AsyncCacheTest.java

@@ -770,7 +770,25 @@ public void getAllBifunction_absent_nullValue(AsyncCache<Int, Int> cache, CacheC
 
   @CacheSpec
   @Test(dataProvider = "caches")
-  public void getAllBifunction_absent_failure(AsyncCache<Int, Int> cache, CacheContext context) {
+  public void getAllBifunction_absent_failure_checkedException(
+      AsyncCache<Int, Int> cache, CacheContext context) {
+    var future = cache.getAll(context.absentKeys(),
+        (keys, executor) -> CompletableFuture.failedFuture(new IOException()));
+    assertThat(future).failsWith(CompletionException.class)
+        .hasCauseThat().isInstanceOf(IOException.class);
+    assertThat(context).stats().hits(0).misses(context.absentKeys().size()).success(0).failures(1);
+    assertThat(logEvents()
+        .withMessage("Exception thrown during asynchronous load")
+        .withThrowable(IOException.class)
+        .withLevel(WARN)
+        .exclusively())
+        .hasSize(1);
+  }
+
+  @CacheSpec
+  @Test(dataProvider = "caches")
+  public void getAllBifunction_absent_failure_runtimeException(
+      AsyncCache<Int, Int> cache, CacheContext context) {
     var future = cache.getAll(context.absentKeys(),
         (keys, executor) -> CompletableFuture.failedFuture(new IllegalStateException()));
     assertThat(future).failsWith(CompletionException.class)
@@ -784,6 +802,23 @@ public void getAllBifunction_absent_failure(AsyncCache<Int, Int> cache, CacheCon
         .hasSize(1);
   }
 
+  @CacheSpec
+  @Test(dataProvider = "caches")
+  public void getAllBifunction_absent_failure_error(
+      AsyncCache<Int, Int> cache, CacheContext context) {
+    var future = cache.getAll(context.absentKeys(),
+        (keys, executor) -> CompletableFuture.failedFuture(new Error()));
+    assertThat(future).failsWith(CompletionException.class)
+        .hasCauseThat().isInstanceOf(Error.class);
+    assertThat(context).stats().hits(0).misses(context.absentKeys().size()).success(0).failures(1);
+    assertThat(logEvents()
+        .withMessage("Exception thrown during asynchronous load")
+        .withThrowable(Error.class)
+        .withLevel(WARN)
+        .exclusively())
+        .hasSize(1);
+  }
+
   @CacheSpec
   @Test(dataProvider = "caches")
   public void getAllBifunction_absent_throwsCheckedException(

gradle/config/spotbugs/exclude.xml

@@ -178,7 +178,10 @@
   </Match>
   <Match>
     <Class name="com.github.benmanes.caffeine.cache.LocalAsyncCache$AsyncBulkCompleter"/>
-    <Method name="apply"/>
+    <Or>
+      <Method name="apply"/>
+      <Method name="error"/>
+    </Or>
     <Bug pattern="ITC_INHERITANCE_TYPE_CHECKING"/>
   </Match>
   <Match>

gradle/plugins/src/main/kotlin/analyze/jcstress.caffeine.gradle.kts

@@ -1,6 +1,5 @@
 import de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis
 import net.ltgt.gradle.errorprone.errorprone
-import org.gradle.kotlin.dsl.named
 
 plugins {
   id("java-library.caffeine")