perf: add new Concat types for children lengths
#1524
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
concat_children
branch
from
7722aa9 to
da4e826
Compare
belav
added a commit
that referenced
this pull request
Apr 4, 2025
Follow on from #1502, using `ValueListBuilder` to replace known `List<Doc>` sizes. - Most of these changes aren't measurable in the benchmarks, many are insignificant, although I suspect this is partly due to the limited code found in the benchmark file. - This PR will increase the performance benefits of #1524 @belav what do you think the best way of replacing a list that uses a collection initializer is? I can either add the items directly into the scratch buffer and manually update `Length` ```C# var docs = new ValueListBuilder<Doc> ([ Modifiers.Print(node.Modifiers, context), Token.Print(node.DelegateKeyword, context), null,null ]); docs.Length = 2; ``` Or create the buffer and then append the items via params. ```C# var docs = new ValueListBuilder<Doc>([null, null, null, null]); docs.Append( Modifiers.Print(node.Modifiers, context), Token.Print(node.DelegateKeyword, context) ); ``` Or Append each item ```C# var docs = new ValueListBuilder<Doc>([null, null, null, null]); docs.Append(Modifiers.Print(node.Modifiers, context)); docs.Append(Token.Print(node.DelegateKeyword, context)); ``` --------- Co-authored-by: Bela VanderVoort <[email protected]>
belav
force-pushed
the
main
branch
4 times, most recently
from
eeaf247 to
9e9ad83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking inspiration from Roslyn I added several implementation of
Concatone for each number of children andWithManyChildren.This lets us use
Concat(params ReadOnlySpan<Doc> values, this way we can useWithTwoChildrenorWithThreeChildrenwhen there is a small numbers of values, only allocating to an array when there is a large number ofDoctypes.This currently saves 2 MB (6% memory usage) however I expect this number to go up when combined with #1502