fix: test on minimal and stable golang versions#183
fix: test on minimal and stable golang versions#183mariocandela merged 6 commits intobeelzebub-labs:mainfrom
Conversation
|
Recent golang exposes more coverage info, and that's why test coverage was failing until I bumped it down to 55% due to golang/go#59590 |
Very strange, perhaps the exclusion of the package “strategies” from the unit tests isn’t working. These are tested by the integration tests. Have you tried testing it locally by replicating the continuous integration pipeline?🙂 |
|
Yep, and it throws the exact same errors. |
|
Looks to be all the builder stuff that's bringing it down: # go tool cover -func=coverage.out
github.com/mariocandela/beelzebub/v3/builder/builder.go:31: setTraceStrategy 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:35: buildLogger 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:56: buildRabbitMQ 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:76: Close 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:88: Run 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:155: build 0.0%
github.com/mariocandela/beelzebub/v3/builder/builder.go:163: NewBuilder 0.0%
github.com/mariocandela/beelzebub/v3/builder/director.go:18: NewDirector 0.0%
github.com/mariocandela/beelzebub/v3/builder/director.go:24: BuildBeelzebub 0.0%
github.com/mariocandela/beelzebub/v3/builder/director.go:48: standardOutStrategy 0.0%
github.com/mariocandela/beelzebub/v3/builder/director.go:55: beelzebubCloudStrategy 0.0%
github.com/mariocandela/beelzebub/v3/builder/director.go:76: rabbitMQTraceStrategy 0.0%
github.com/mariocandela/beelzebub/v3/main.go:11: main 0.0%
github.com/mariocandela/beelzebub/v3/main.go:45: failOnError 0.0%
github.com/mariocandela/beelzebub/v3/parser/configurations_parser.go:97: Init 100.0%
github.com/mariocandela/beelzebub/v3/parser/configurations_parser.go:107: ReadConfigurationsCore 100.0%
github.com/mariocandela/beelzebub/v3/parser/configurations_parser.go:123: ReadConfigurationsServices 87.5%
github.com/mariocandela/beelzebub/v3/parser/configurations_parser.go:148: gelAllFilesNameByDirName 100.0%
github.com/mariocandela/beelzebub/v3/parser/configurations_parser.go:163: readFileBytesByFilePath 100.0%
github.com/mariocandela/beelzebub/v3/plugins/beelzebub-cloud.go:27: InitBeelzebubCloud 100.0%
github.com/mariocandela/beelzebub/v3/plugins/beelzebub-cloud.go:35: SendEvent 90.0%
github.com/mariocandela/beelzebub/v3/plugins/beelzebub-cloud.go:61: GetHoneypotsConfigurations 94.4%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:72: String 100.0%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:83: FromStringToLLMProvider 100.0%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:94: InitLLMHoneypot 100.0%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:101: buildPrompt 100.0%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:154: openAICaller 87.5%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:193: ollamaCaller 83.3%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:224: ExecuteModel 100.0%
github.com/mariocandela/beelzebub/v3/plugins/llm-integration.go:244: removeQuotes 100.0%
github.com/mariocandela/beelzebub/v3/protocols/protocol_manager.go:20: InitProtocolManager 100.0%
github.com/mariocandela/beelzebub/v3/protocols/protocol_manager.go:27: SetProtocolStrategy 100.0%
github.com/mariocandela/beelzebub/v3/protocols/protocol_manager.go:32: InitService 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:54: String 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:65: String 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:87: GetInstance 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:132: setStrategy 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:136: TraceEvent 100.0%
github.com/mariocandela/beelzebub/v3/tracer/tracer.go:144: updatePrometheusCounters 100.0%
total: (statements) 55.1% |
Excluded from unite test code coverage builder and director, because covered by integration tests. Signed-off-by: Mario Candela <mario.candela.personal@gmail.com>
codecov exclude temporary code coverage Signed-off-by: Mario Candela <mario.candela.personal@gmail.com>
|
Looks like it brought that up to ~85% |
Signed-off-by: James Hodgkinson <james@terminaloutcomes.com>
Awesome! I will merge that after the rate limit by codecov: Thanks for your time mate 🥇 |
|
Glad to help 🥳 |
All Submissions: