Feat: Add FallbackCommand for HTTP Strategy, refactor packages strategies#175
Merged
mariocandela merged 10 commits intobeelzebub-labs:mainfrom Mar 13, 2025
bryannolen:strat-refactor
Merged
Feat: Add FallbackCommand for HTTP Strategy, refactor packages strategies#175mariocandela merged 10 commits intobeelzebub-labs:mainfrom bryannolen:strat-refactor
mariocandela merged 10 commits intobeelzebub-labs:mainfrom
bryannolen:strat-refactor
Conversation
* Move each strategy into its own package.
* Clean up main http response builder.
* Add support for a Fallback Command for HTTP Strategy:
* Allows you to specify a Command that is executed if all other
commands do not match. This is needed as golang slice ranges are
non-deterministic so we cannot assume the last entry in the config
will be processed last.
* Move each strategy into its own package.
* Clean up main http response builder.
* Add support for a Fallback Command for HTTP Strategy:
* Allows you to specify a Command that is executed if all other
commands do not match. This is needed as golang slice ranges are
non-deterministic so we cannot assume the last entry in the config
will be processed last.
Collaborator
|
HI @bryannolen, |
Contributor
Author
|
I have merged in the History changes from 3.3.9 as well now too. |
…ean up SSH trace events to be clearier.
Contributor
Author
|
I have also added a thread-safe HistoryStore that can be re-used across strategies. (maps in golang are not inherantly thread safe, and the strategies are all heavy users of goroutines) |
Collaborator
|
Hello mate, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup and refactor of the Strategies.
FallbackCommand- currently implemeted only for HTTP Strategy.Usage Example:
=======
Checklist:
All Submissions:
New Feature Submissions:
Changes to Core Features: