Add suport for TLS based HTTP connections.#158
Add suport for TLS based HTTP connections.#158mariocandela merged 3 commits intobeelzebub-labs:mainfrom bryannolen:main
Conversation
|
Hi @bryannolen, Thank you for contributing to beelzebub ❤️, very appreciated. |
mariocandela
left a comment
There was a problem hiding this comment.
You did a great job, thank you so much for the time you invested. ❤️
I’ve left some comments; once these issues are resolved, what do you think about adding an integration test for this new scenario?
If you don’t have the time, I can make these changes.
Thanks a lot!
|
Happy to help, its a cool project. I have some ideas for adding TLS support to TCP Socket connections, but that will require some thought. |
|
As for the integration test, I don't have time until next month to do that, but good idea though. |
Don't worry Bryan, we'll add these tests later on. I'll open an issue for that. Thank you so much for your contribution! I hope to see you here again. If you're interested in writing a blog post for Beelzebub Labs, you're more than welcome. I’ve read your blog, and your articles are very interesting ❤️ |
#159 🚀 |
Add support for TLS in the HTTP strategy.
This adds 2 new optional fields to the Strategy configuration -
TLSKeyPathandTLSCertPath. These are passed as provided to thehttp.ListenAndServeTLSfunction if they are not empty. Missing and invalid file path errors are handled by the underlying library.Also correct a function typo (
Fprintfwas used, but no format string was provided), and reorder imports to improve readbility.All Submissions:
New Feature Submissions:
Changes to Core Features: