feat: preserve IP address order #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsypherPunk
force-pushed
the
preserve-ip-order
branch
from
a5367ad to
d5f9718
Compare
as part of bee-san#651, IP addresses are deduplicated; as this uses a `BTreeSet`, the original order is not necessarily retained. use [`retain()`](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.retain) to remove duplicated and/or excluded IPs, mutating the original list of IPs but preserving the original order.
PsypherPunk
force-pushed
the
preserve-ip-order
branch
from
d5f9718 to
9bba659
Compare
bee-san
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of #651, IP addresses are deduplicated; as this uses a
BTreeSet, the original order is not necessarily retained.retain()to remove duplicated and/or excluded IPs, mutating the original list of IPs but preserving the original orderVecto aBTreeSetto improve performance of those checks