Fixes #645: Add arm64 Docker image build #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PsypherPunk would you mind having a look at this? I'd like to have it count towards Hacktoberfest. |
|
@mcamou, this doesn't quite work: the
Based on those same docs. and some testing, it looks like we need the - name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3With that in place both images appear to build correctly. |
mcamou
force-pushed
the
add-arm64-docker-build
branch
from
d7f0dfa to
ea428a1
Compare
|
@PsypherPunk thank you for that. I did it from memory and had forgotten about that. I've amended the commit and force-pushed to keep the commit history clean. |
|
Looks good (and linking to this as evidence)—thanks. Happy Hacktoberfest! |
PsypherPunk
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.