refactor: move address-related functions #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move functions for address-parsing/-resolution to a submodule. fix bee-san#580
PsypherPunk
force-pushed
the
580-public-address-functions
branch
from
bc8d8d7 to
e8a66ab
Compare
|
Any way we can add docstrings and doc-string-tests like in our other API things? Since this goes to docs.rs it'd be cool to expose it on there too along with nice tests 🙈 Thank you for your hard work 🦾 |
PsypherPunk
force-pushed
the
580-public-address-functions
branch
from
c8f5b0c to
e4e998e
Compare
bee-san
approved these changes
May 9, 2024
|
Awesome work!!! 👏🏻 If you happen to have free time and want to work on something but not sure what, #531 would be awesome to fix up 👀 |
|
@bee-san, re. #531 I've brought that change up to speed with recent refactoring; as I don't have permission to change the original branch, the update is over at I'll work through your comments on the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move functions for address-parsing/-resolution to a submodule.
fixes #580
As per #580, I've refactored the address-related functions from
main.rsto their own submodule (along with related tests); onlyparse_addressesandparse_addressare public, the other functions appear to be largely ancillary…?