Update for ARM; #464
Merged
Update for ARM; #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building master on an ARM64 Mac OS X fails with the following error:
running "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-arch" "arm64" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/Users/marc/git/rust/RustScan/target/debug/build/ring-df487ff6260d90ee/out/aesv8-armx-linux64.o" "/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S"
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:18:17: error: unexpected token in '.section' directive
.section .rodata
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:28:1: error: unknown directive
.hidden GFp_aes_hw_set_encrypt_key
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:29:1: error: unknown directive
.type GFp_aes_hw_set_encrypt_key,%function
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:161:1: error: unknown directive
.size GFp_aes_hw_set_encrypt_key,.-GFp_aes_hw_set_encrypt_key
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:163:1: error: unknown directive
.hidden GFp_aes_hw_encrypt
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:164:1: error: unknown directive
.type GFp_aes_hw_encrypt,%function
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:191:1: error: unknown directive
.size GFp_aes_hw_encrypt,.-GFp_aes_hw_encrypt
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:193:1: error: unknown directive
.hidden GFp_aes_hw_decrypt
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:194:1: error: unknown directive
.type GFp_aes_hw_decrypt,%function
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:221:1: error: unknown directive
.size GFp_aes_hw_decrypt,.-GFp_aes_hw_decrypt
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
.hidden GFp_aes_hw_ctr32_encrypt_blocks
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:224:1: error: unknown directive
.type GFp_aes_hw_ctr32_encrypt_blocks,%function
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:403:1: error: unknown directive
.size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
^
/Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:407:19: error: unexpected token in '.section' directive
.section .note.GNU-stack,"",%progbits
^
thread 'main' panicked at 'execution failed', /Users/marc/.cargo/registry/src/mygithub.libinneed.workers.dev-1ecc6299db9ec823/ring-0.16.15/build.rs:664:9
note: run with
RUST_BACKTRACE=1environment variable to display a backtracewarning: build failed, waiting for other jobs to finish...
error: build failed
ring is pulled in by rust-dns-resolver (ring 0.16.15 --> rustls v0.17.0 --> trust-dns-resolver v0.19.5)
Upgrading rust-dns-resolver to 0.21.1 and patching the lookup_up method fixed my issue.
(Cargo.lock changes - I'm afraid I'm not familar enough with rust to really understand these changes, it seems cargo made these changes when I rebuilt the project)