Skip to content

Conversation

mattcorbin
Copy link

I added in a progress bar for the base Scanner.run(). I had to reorganize the println!("Open {}", socket.to_string().purple()); to be after the scan finishes, as outputting that progress in addition to the bar caused the bar to keep getting pushed down and recreated. There may be a more sophisticated way to handle this as I'm not super familiar with either RustScan and the indicatif crate, so I wanted to post this up to get some preliminary feedback.

fixes #88

@mattcorbin mattcorbin marked this pull request as draft August 31, 2020 01:06
@mattcorbin mattcorbin marked this pull request as ready for review August 31, 2020 01:06
@bee-san bee-san self-requested a review September 1, 2020 00:38
@bernardoamc
Copy link
Contributor

Hey @mattcorbin, thanks for the contribution! This library has a heavy set of dependencies, do you know if the rust-world has any lightweight alternatives? :)

@mattcorbin
Copy link
Author

@bernardoamc That was actually the crate linked in #88 so I just went with that one to start with. It looks like pbr is the main alternative, and looks to me to be a little bit lighter. I can try to swap it around to use pbr, as the other options I've found are either very beta or abandoned.

be post scan instead of during as it caused issues with the progress bar.
@mattcorbin
Copy link
Author

@bernardoamc I swapped out indicatif for pbr, the code structure is identical and the actual progress bar itself seems quite a bit nicer IMO. Let me know what you think.

@bernardoamc
Copy link
Contributor

This is awesome, thanks @mattcorbin. Could you rebase this with master? This is conflicting with my latest changes. 🙇

@bernardoamc
Copy link
Contributor

@bee-san do you want to run this PR locally? 😄

@bernardoamc bernardoamc self-requested a review September 14, 2020 23:59
@bee-san
Copy link
Owner

bee-san commented Oct 4, 2020

Hey! Thanks so much for your work <3 Unfortunately we think a progress bar would be unmaintainable in the future as we need different types of scans / scripts etc.

Thank you SO much for contributing though! You will get credit on the README for writing code (even if it wasn't merged) :D

@all-contributors add @mattcorbin for code

@allcontributors
Copy link
Contributor

@bee-san

I've put up a pull request to add @mattcorbin! 🎉

@bee-san bee-san closed this Oct 4, 2020
@mattcorbin mattcorbin mentioned this pull request Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bars
3 participants