-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Progress bar for base scan progress #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @mattcorbin, thanks for the contribution! This library has a heavy set of dependencies, do you know if the rust-world has any lightweight alternatives? :) |
@bernardoamc That was actually the crate linked in #88 so I just went with that one to start with. It looks like pbr is the main alternative, and looks to me to be a little bit lighter. I can try to swap it around to use pbr, as the other options I've found are either very beta or abandoned. |
be post scan instead of during as it caused issues with the progress bar.
@bernardoamc I swapped out |
This is awesome, thanks @mattcorbin. Could you rebase this with master? This is conflicting with my latest changes. 🙇 |
@bee-san do you want to run this PR locally? 😄 |
Hey! Thanks so much for your work <3 Unfortunately we think a progress bar would be unmaintainable in the future as we need different types of scans / scripts etc. Thank you SO much for contributing though! You will get credit on the README for writing code (even if it wasn't merged) :D @all-contributors add @mattcorbin for code |
I've put up a pull request to add @mattcorbin! 🎉 |
I added in a progress bar for the base
Scanner.run()
. I had to reorganize theprintln!("Open {}", socket.to_string().purple());
to be after the scan finishes, as outputting that progress in addition to the bar caused the bar to keep getting pushed down and recreated. There may be a more sophisticated way to handle this as I'm not super familiar with either RustScan and the indicatif crate, so I wanted to post this up to get some preliminary feedback.fixes #88