Include load in summaries#216
Conversation
fmeum
force-pushed
the
95-loads
branch
2 times, most recently
from
a107264 to
aed67db
Compare
|
Some tests are failing due to differing repository names. I can look into this when there is general consensus on the approach. I'm also happy to make this new behavior configurable in the template. |
tetromino
left a comment
tetromino
left a comment
There was a problem hiding this comment.
Looks good! I updated the branch after the recent churn, which hopefully should fix test failures.
One nit: I would put a blank line between load(...) and the usage of the symbol, as in buildifier-formatted output.
src/main/java/com/google/devtools/build/stardoc/rendering/MarkdownUtil.java
Show resolved
Hide resolved
Rules, providers, functions and aspects now have a small `load` statement in their summary. Aspects additionally include a copyable `--aspects` flag.
|
The WORKSPACE tests are failing since they use a different repo name for Stardoc, which now appears in |
Excellent question! We may have to tag those tests "manual" + bazel version for which the golden was generated; in #232, I am adding a way to auto-update tests whose goldens are valid only for a particular Bazel release. |
|
I'll wait for #232 then, let me know what I need to do after it has been merged. |
In the interests of brevity and maintainability, we are only interested in the following tests for --noenable_bzlmod: * multiple_files * same_level_file * table_of_contents * local_repository (this one needs no forking)
Otherwise, the test output looks very odd.
tetromino
left a comment
tetromino
left a comment
There was a problem hiding this comment.
LGTM.
I took the liberty to fix up the tests, since the merge + necessary tagging and bazelci setup is a bit tricky.
2 participants
Rules, providers, functions and aspects now have a
loadstatement in their summary. Aspects additionally include a copyable--aspectsflag.Fixes #95