Support additional_linker_inputs in swift_binary#1584
Merged
adincebic merged 6 commits intobazelbuild:masterfrom Nov 11, 2025
Merged
Support additional_linker_inputs in swift_binary#1584adincebic merged 6 commits intobazelbuild:masterfrom
additional_linker_inputs in swift_binary#1584adincebic merged 6 commits intobazelbuild:masterfrom
Conversation
5e49b82 to
ac269f8
Compare
Contributor
Author
|
@brentleyjones I updated the PR. I left |
brentleyjones
approved these changes
Sep 30, 2025
Collaborator
brentleyjones
left a comment
There was a problem hiding this comment.
While this is technically a breaking change, in a way that could be hard to fix in non-root modules, it doesn't look like any public modules was using swiftc_inputs for linker inputs. So I'm fine with this if @keith is.
Member
|
sure, i like naming matching other rules |
064b690 to
6f43932
Compare
6f43932 to
5d72c88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1511