2.x cherry-pick: Add clang_deps attr to mixed_language_library (#1540)#1542
Merged
luispadron merged 1 commit intobazelbuild:2.xfrom Jun 12, 2025
Merged
Conversation
At Square, we're using a headermap for the Swift generated header, so that the objective-C half of a module is able to import it using `#import <Module/Module-Swift.h>`. This headermap target can't be placed in `deps`, as doing so creates a dependency cycle. Here is an example of what the use case looks like: bazelbuild/rules_swift@master...jschear:rules_swift:js/demo_swift_header_imports_in_clang_half ``` header_map( name = "swift_headermap", module_name = "MixedAnswer", propagate_include = False, # This relies on us knowing the naming scheme used for internal targets in mixed_language_library, which is not ideal. deps = ["MixedAnswer_swift"], ) mixed_language_library( name = "MixedAnswer", hdrs = ["MixedAnswer.h"], clang_copts = [ "-I$(execpath :swift_headermap)", "-I.", ], clang_deps = [":swift_headermap"], clang_srcs = [ "MixedAnswer.m", "MixedAnswerPrivate.m", "MixedAnswerPrivate.h", ], enable_modules = True, module_name = "MixedAnswer", swift_srcs = [ "MixedAnswer.swift", ], target_compatible_with = ["@platforms//os:macos"], ) ```
clang_deps attr to mixed_language_library (#1540)clang_deps attr to mixed_language_library (#1540)
luispadron
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Square, we're using a headermap for the Swift generated header, so that the objective-C half of a module is able to import it using
#import <Module/Module-Swift.h>.This headermap target can't be placed in
deps, as doing so creates a dependency cycle.Here is an example of what the use case looks like: master...jschear:rules_swift:js/demo_swift_header_imports_in_clang_half