Add support for package_name in mixed_language_library#1458
Merged
brentleyjones merged 1 commit intomasterfrom Nov 22, 2024
Merged
Add support for package_name in mixed_language_library#1458brentleyjones merged 1 commit intomasterfrom
package_name in mixed_language_library#1458brentleyjones merged 1 commit intomasterfrom
Conversation
luispadron
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
force-pushed
the
luis/add-package-name-mixed-lang-library
branch
from
6733cd8 to
5e9ab0f
Compare
luispadron
force-pushed
the
luis/add-package-name-mixed-lang-library
branch
from
5e9ab0f to
65e1d89
Compare
aaronsky
approved these changes
Nov 22, 2024
brentleyjones
approved these changes
Nov 22, 2024
Contributor
Author
|
@brentleyjones mind admin merging, believe the ci failure is that bazel 8 issue we need to fix |
luispadron
added a commit
that referenced
this pull request
Dec 10, 2024
brentleyjones
pushed a commit
that referenced
this pull request
Dec 10, 2024
Taking #1458 into the 2.x branch and will tag 2.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attr was missing from the
swift_library.