Closed
Conversation
Needed to support Bazel HEAD. This changes the generated docs to include load statements with `@rules_swift`. As part of rules_swift 3.0 we can change all references to the new form as well. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Oct 15, 2024
Collaborator
Author
|
Until bazelbuild/stardoc#255 is fixed, we probably shouldn't do this. |
Contributor
|
I made #1462 to try and get the rest of the way there and unblock us, but I may have gone overboard on the implementation. Hope it was helpful for me to try. |
auto-merge was automatically disabled
February 10, 2025 20:12
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to support Bazel HEAD.
This changes the generated docs to include load statements with
@rules_swift. As part of rules_swift 3.0 we can change all references to the new form as well.