Add the swift_module_mapping rule#1329
Merged
brentleyjones merged 1 commit intomasterfrom Oct 2, 2024
Merged
Conversation
This change only adds the new rule and its provider. The build flag (mentioned in documentation) and compilation support will be added in subsequent changes. PiperOrigin-RevId: 486235761 (cherry picked from commit 6b56b01) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 1, 2024
This change only adds the new rule and its provider. The build flag (mentioned in documentation) and compilation support will be added in subsequent changes. PiperOrigin-RevId: 486235761
luispadron
approved these changes
Oct 2, 2024
Contributor
luispadron
left a comment
luispadron
left a comment
There was a problem hiding this comment.
Should this be added to https://github.com/bazelbuild/rules_swift/blob/master/doc/rules.md
Collaborator
Author
|
Probably, when it starts to do something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change only adds the new rule and its provider. The build flag (mentioned in documentation) and compilation support will be added in subsequent changes.
PiperOrigin-RevId: 486235761
(cherry picked from commit 6b56b01)