Apply swift.add_target_name_to_output only to outputs that need it#1217
Merged
brentleyjones merged 1 commit intomasterfrom Jun 18, 2024
Merged
Apply swift.add_target_name_to_output only to outputs that need it#1217brentleyjones merged 1 commit intomasterfrom
swift.add_target_name_to_output only to outputs that need it#1217brentleyjones merged 1 commit intomasterfrom
Conversation
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
force-pushed
the
bj/fix-target-name
branch
2 times, most recently
from
573d5de to
acdb5e7
Compare
brentleyjones
commented
Jun 17, 2024
Collaborator
Author
brentleyjones
left a comment
brentleyjones
left a comment
There was a problem hiding this comment.
VFS overlay and explicit module map changed the name to be based on the target (since they don't need to be named after the module). The rest of the changes made the flag apply to fewer output paths, since they already included the target name in them.
brentleyjones
force-pushed
the
bj/fix-target-name
branch
2 times, most recently
from
ce33c61 to
67b5448
Compare
In particular, only outputs that need to have the module name as part of the filename. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/fix-target-name
branch
from
67b5448 to
4f6ecdf
Compare
luispadron
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, only outputs that need to have the module name as part of the filename.