Merged
Conversation
dzbarsky
force-pushed
the
zbarsky/collect-deps
branch
from
8b363d4 to
104a501
Compare
illicitonion
approved these changes
Sep 29, 2025
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
It's a little surprising how many .to_list() calls we're adding here, but I guess these were all just hidden inside collect_deps, so it'll be easier for us to remove these in the future if we want to try to, than it was before! Thank you!
Contributor
Author
Exactly. These are all terminal nodes also whereas before we would call to_list on lib to lib edges. |
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 7, 2025
…_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 8, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 13, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 14, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 15, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 16, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 20, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 815679316
copybara-service bot
pushed a commit
to google/crubit
that referenced
this pull request
Oct 21, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 822050008 Change-Id: I73c6feb0335651979c7b4ca637623385e9010704
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 21, 2025
bazelbuild/rules_rust#3634, which updates the deps and proc_macro_deps of rustc_compile_action and collect_deps to list. PiperOrigin-RevId: 822050008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key insight is that
depsandproc_macro_depsmust be disjoint, so the depset.to_list is not doing any deduping. With that out of the way, we do a bit of code rearranging to avoid converting our lists of deps to depsets too early; in general it is best to construct the output depsets when creating the providers, not in the middle of the rule implementations.Before:
After:
