Add cfg = proc_macro_host_transition to all rules #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rust_library rule specifies a cfg option. This performs transitions in order to support WASM. Other rules, such as rust_binary, do not have this configuration, which causes Bazel to build and link some libraries into the final binary twice, resulting in compilation errors. This is detailed in pull request bazelbuild#294 and issue bazelbuild#300. The issue was introduced in commit 7cde1e4. This adds the example from @colin353 in PR bazelbuild#294 as an example that would otherwise fail. Fixes bazelbuild#300
|
@dfreese thanks for writing this! Looks great! |
dfreese
added a commit
to dfreese/rules_rust
that referenced
this pull request
Apr 20, 2020
This mostly reverts commit a1d8936, removing the proc_macro_host_transition from most rules. This fixes bazelbuild#305, by no longer having a transition on rust_binary. It still solves bazelbuild#300 by adding this transition to rust_proto_library and rust_grpc_library. Those rules are meant to mirror rust_library, so they should share the same cfg values. Sharing the same configuration means that rust_proto_library or rust_grpc_library can be dependencies to rust_library or rust_binary and not cause another configuration of the library to be generated. The example introduced by bazelbuild#301 is moved in this commit into a subfolder to provide a more clear directory structure.
damienmg
pushed a commit
that referenced
this pull request
Apr 21, 2020
This mostly reverts commit a1d8936, removing the proc_macro_host_transition from most rules. This fixes #305, by no longer having a transition on rust_binary. It still solves #300 by adding this transition to rust_proto_library and rust_grpc_library. Those rules are meant to mirror rust_library, so they should share the same cfg values. Sharing the same configuration means that rust_proto_library or rust_grpc_library can be dependencies to rust_library or rust_binary and not cause another configuration of the library to be generated. The example introduced by #301 is moved in this commit into a subfolder to provide a more clear directory structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust_library rule specifies a cfg option. This performs transitions
in order to support WASM. Other rules, such as rust_binary, do not have
this configuration, which causes Bazel to build and link some libraries
into the final binary twice, resulting in compilation errors. This is
detailed in pull request #294 and issue #300. The issue was introduced
in commit 7cde1e4.
This adds the example from @colin353 in PR #294 as an example that would
otherwise fail.
Fixes #300