Add coverage invocations to presubmit#612
Closed
UebelAndre wants to merge 4 commits intobazelbuild:mainfrom
Closed
Add coverage invocations to presubmit#612UebelAndre wants to merge 4 commits intobazelbuild:mainfrom
coverage invocations to presubmit#612UebelAndre wants to merge 4 commits intobazelbuild:mainfrom
Conversation
UebelAndre
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
UebelAndre
force-pushed
the
coverage
branch
2 times, most recently
from
22f5332 to
e4984e8
Compare
Contributor
Author
|
This PR now reveals that coverage is broken for |
Member
|
fixing CI in #615 |
Contributor
Author
|
I dropped coverage tests on windows as it seems extra broken. At least for other platforms regression testing is locked in. |
Contributor
Author
keith
approved these changes
Mar 13, 2026
Contributor
Author
|
cc @armandomontanez maybe 🙏 |
Contributor
Author
armandomontanez
approved these changes
Mar 23, 2026
Collaborator
|
Sorry for the radio silence, ment to get to this last week. I'll help usher this in. |
armandomontanez
added
P1
trybka
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds tests for
maco_arm64which today is the more common MacOS platform.