fix: Update to rules_swift 3.0.2#2877
Conversation
Removes requirement that windows users have `swiftc.exe` installed by using version that includes bazelbuild/rules_swift#1502
| bazel_dep( | ||
| name = "rules_swift", | ||
| version = "2.4.0", | ||
| version = "3.0.2", |
There was a problem hiding this comment.
We only want to update this dep if we need a higher version to function. Sounds like for your particular issue you want to update your root module rules_swift version.
There was a problem hiding this comment.
Users of rules_apple building on windows need a higher version of rules_swift due to a bug that was fixed and first released in 3.0.
I worked with @luispadron to get protocolbuffers/protobuf#25437 merged into protobuf, and we had to use the solution you're suggesting in order to avoid breaking windows users. However, adding a dependency directly on rules_swift from protobuf has created headaches for other libraries downstream of us, and so we're actively looking for ways to remove this dep from protobuf.
There was a problem hiding this comment.
I'm discussing our versioning plans with others. I think we should minimally port this fix to 2.x and bump this to that version. Ideally we don't increase past major version if we don't need to.
There was a problem hiding this comment.
FWIW the rules_apple bazel 9 branch will make this change too #2868
There was a problem hiding this comment.
Closing thie PR because in protocolbuffers/protobuf#25708 the dependency on rules_apple was been removed from protobuf in main, and that change will be released in 34.0 later this month, which also means we have removed its dependency on rules_swift.
|
@brentleyjones - I still think it is a good idea to pursue getting the bug fix backported to |
Removes requirement that windows users have
swiftc.exeinstalled by using version that includes bazelbuild/rules_swift#1502