7.0.0 README updates and minor code changes#1714
Merged
simuons merged 2 commits intobazel-contrib:masterfrom Mar 10, 2025
Merged
7.0.0 README updates and minor code changes#1714simuons merged 2 commits intobazel-contrib:masterfrom
simuons merged 2 commits intobazel-contrib:masterfrom
Conversation
Contains many editorial improvements to and some extra information in the README, along with a few small improvements to the code. Broken out from bazel-contrib#1710, and part of bazel-contrib#1482 and bazel-contrib#1652. Specifically: - Adds more info on translating `@rules_scala` to `@io_bazel_rules_scala` for dependencies via repo mapping. - Merges information about the previously planned `rules_scala` 8.0.0 release into the information for 7.0.0, since it seems we may make only one major release. - Improves information about `protobuf` support for versions before v28, Scala 2.11, and the upcoming Bzlmod `compatibility_level` setting. - In `scala_config.bzl`, changes the private `_default_scala_version()` to the public `DEFAULT_SCALA_VERSION`. - Adds `allow_empty = True` to a `glob` expression in `//test/semanticdb:lib_with_tempsrc`. - Removes Scala 2.11 test cases from `test_thirdparty_version.sh` and `test_version.sh`. This change is smaller and more focused than bazel-contrib#1710, and should ultimately make that pull request smaller and/or easier to review. The motivations for the individual changes are: - The public `DEFAULT_SCALA_VERSION` constant makes this value accessible to the upcoming module extension. - `glob` requires an explicit `allow_empty = True` parameter in Bazel 8, in which `--incompatible_disallow_empty_glob` defaults to `True`. - ScalaPB 0.9.8, the last version compatible with Scala 2.11, does not support `protobuf` v25.6 or later. For this reason, we must remove the Scala 2.11 test cases, as documented in the `README.md` updates. See also bazel-contrib#1712. We should consider dropping Scala 2.11 support at this point, since there's no ScalaPB release for it that supports later versions of `protobuf`. That, and we could remove some of the special case code added in the following changes, amongst other 2.11 support details: - bazel-contrib#1631 - bazel-contrib#1648 - bazel-contrib#1687 - bazel-contrib#1688
Provided a better explanation for using `rules_python` 0.38.0 for now. Improved some of the language in the Bazel 6.5.0 compatibility section.
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Mar 7, 2025
Also removes an extra line from the `WORKSPACE` snippet of the "Getting started" section.
bartoszkosiorek
approved these changes
Mar 7, 2025
Contributor
bartoszkosiorek
left a comment
bartoszkosiorek
left a comment
There was a problem hiding this comment.
Looks great to me.
Collaborator
Author
|
BTW, we could bump |
simuons
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contains many editorial improvements to and some extra information in the README, along with a few small improvements to the code. Broken out from #1710, and part of #1482 and #1652.
Specifically:
Adds more info on translating
@rules_scalato@io_bazel_rules_scalafor dependencies via repo mapping.Merges information about the previously planned
rules_scala8.0.0 release into the information for 7.0.0, since it seems we may make only one major release.Improves information about
protobufsupport for versions before v28, Scala 2.11, and the upcoming Bzlmodcompatibility_levelsetting.In
scala_config.bzl, changes the private_default_scala_version()to the publicDEFAULT_SCALA_VERSION.Adds
allow_empty = Trueto aglobexpression in//test/semanticdb:lib_with_tempsrc.Removes Scala 2.11 test cases from
test_thirdparty_version.shandtest_version.sh.Motivation
This change is smaller and more focused than #1710, and should ultimately make that pull request smaller and/or easier to review.
The motivations for the individual changes are:
The public
DEFAULT_SCALA_VERSIONconstant makes this value accessible to the upcoming module extension.globrequires an explicitallow_empty = Trueparameter in Bazel 8, in which--incompatible_disallow_empty_globdefaults toTrue.ScalaPB 0.9.8, the last version compatible with Scala 2.11, does not support
protobufv25.6 or later. For this reason, we must remove the Scala 2.11 test cases, as documented in theREADME.mdupdates. See also Upgrade toprotobufv25.6 #1712.We should consider dropping Scala 2.11 support at this point, since there's no ScalaPB release for it that supports later versions of
protobuf. That, and we could remove some of the special case code added in the following changes, amongst other 2.11 support details:ProtobufAdapters andScalaPBCodeGeneratorwrappers #1648protoc-bridgeto 0.9.8 for Scala >= 2.12 #1688