feat: support Gemfile and .gemspec that do not live at the root of the workspace
#249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add hello_world gem example using JRuby 10.0.0.0 - Remove standard gem dependency to avoid prism compilation issues - Use require_relative for local file dependencies - Update gem checksums to match simplified dependency tree 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Extract Speaker-specific tests from hello_world_spec.rb to speaker_spec.rb - Add corresponding rb_test target in BUILD.bazel for the new spec file - Keep version-related tests in the main HelloWorld spec file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add structured context blocks for better test organization - Use describe "#name" to clearly identify method being tested - Separate contexts for different scenarios (no name vs provided name) - Improve test readability following RSpec best practices 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add project-level README.md explaining deep gem structure and purpose - Document how to reference files using standard Bazel package notation - Remove default gem README.md template from hello_world subdirectory - Include examples of MODULE.bazel configuration with deep gem references - Provide testing instructions and project structure overview - Format all lines to stay within 100 character limit 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove ruby-build version specification and related comments - Keep only essential version_file configuration for Ruby toolchain - Streamline configuration to focus on core functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Code cleanup:
- Remove commented require statements from hello_world.rb for cleaner code
Enhanced test coverage:
- Add comprehensive tests for Speaker#message method (default and custom name)
- Add comprehensive tests for Speaker#hi method with stdout output verification
- Improve test description consistency ("returns" vs "uses")
- Achieve 100% test coverage for Speaker class (6 test examples)
All tests pass successfully with complete method coverage.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
|
@cgrindel Just for the record, you don't have to support all Ruby versions for this example. |
|
@p0deje I reduced the list of Ruby versions to just jruby. I can work on getteing the other versions working, just let me know which ones you would like to see. |
p0deje
approved these changes
Aug 3, 2025
Please. No one needs to see how the sausage is made. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rb_{binary|test}cannot be found.