Skip to content

fix: tweak the delay factor when downloading artifacts#244

Merged
kormide merged 1 commit intomainfrom
reduce-delay-factor
Mar 4, 2025
Merged

fix: tweak the delay factor when downloading artifacts#244
kormide merged 1 commit intomainfrom
reduce-delay-factor

Conversation

@kormide
Copy link
Copy Markdown
Collaborator

@kormide kormide commented Feb 27, 2025

Experimentally, I found the current delay factor causes a full retry sequence to take about 2m30s which seems long both for the CLI and for the GitHub app. Tweak the factor to take about 30s and output the retry attempts.

Publish to BCR
Loading template files from /home/derek/Code/bazel-lib/.bcr
Creating entry for module version 3.0.0 in /home/derek/Code/bazel-central-registry
Fetching release archive https://github.com/bazel-contrib/bazel-lib/releases/download/v3.0.0/bazel-lib-v3.0.0.tar.gz
Failed to download artifact; Request failed with status code 404
Retry atempt 1 / 3...
Failed to download artifact; Request failed with status code 404
Retry atempt 2 / 3...
Failed to download artifact; Request failed with status code 404
Retry atempt 3 / 3...
Failed to download release archive https://github.com/bazel-contrib/bazel-lib/releases/download/v3.0.0/bazel-lib-v3.0.0.tar.gz; received status code 404
Double check that the url in /home/derek/Code/bazel-lib/.bcr/source.template.json is correct and that the archive has been uploaded by the time this command is run. 

@kormide kormide force-pushed the reduce-delay-factor branch from 4f0d18f to cff9afc Compare February 27, 2025 00:37
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows bot commented Feb 27, 2025

Test

5 test targets passed

Targets
//dist/cli:cli_test [k8-fastbuild]        203ms
//e2e/cli:test [k8-fastbuild]             5s
//e2e/github-webhook:test [k8-fastbuild]  58s
//src/application/cli:test [k8-fastbuild] 9s
//src/domain:test [k8-fastbuild]          12s

Total test execution time was 1m 23s. 7 tests (58.3%) were fully cached saving 473ms.


Buildifier      Format      Lint [.]

@kormide kormide force-pushed the reduce-delay-factor branch 2 times, most recently from 9e50d32 to 7a58de9 Compare February 27, 2025 00:55
@kormide kormide marked this pull request as ready for review February 27, 2025 00:56
@kormide kormide requested a review from alexeagle February 27, 2025 00:56
@kormide kormide force-pushed the reduce-delay-factor branch from 7a58de9 to 5980ac5 Compare March 4, 2025 01:15
@kormide kormide merged commit 416834e into main Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants