feat(diff_test): adding a hermetic toolchain #1056
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to add a diff hermetic toolchain based on https://github.com/uutils/diffutils
manuelnaranjo
force-pushed
the
mnaranjo/diffutils
branch
from
cc325fe to
f5efe00
Compare
manuelnaranjo
changed the title
alexeagle
approved these changes
Apr 21, 2025
|
I didn't fully test if IIRC, I think it lacks -r which would need to be implemented on starlark/shell |
|
I got stuck trying to decide if https://gitlab.arm.com/bazel/rules_diff fully covers this use case or not. |
When I did the contribution I think I tried to research the differences and can't remember why I didn't go that way, most likely it's because ir wasn't in the BCR yet. Also I'm not 100% sure you want bazel-lib to depend on it, maybe it's best to vendor the binaries once again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add a diff hermetic toolchain based on
https://github.com/uutils/diffutils
Closes: #529