add MobileCoreServices framework #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tautvilas many thanks for the PR 👏 Could you just amend your commit with a long description about Why this change is needed (scenario and the fix)? I can fairly see someone in the future trying to understand why it is in the codebase, and a long git commit could help for the maintenance while checking the codebase history. |
this fixes IOS Build error: Undefined symbol: _kUTTypeJPEG, Undefined symbol: _kUTTypePNG these symobls are defined in MobileCoreServices library, so the lib must be linked in the podspec the build error can be reproduced when using use_frameworks! in project Podfile that has react-native-image-resizer as a dependency
tautvilas
force-pushed
the
podspec-fix
branch
from
6b28d6c to
f1d69ea
Compare
|
Hey @PierreCapo thanks, I did that |
PierreCapo
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MobileCoreServices framework (fixes #327)