Skip to content

fix: android builds failing because of incompatible kotlin version used by appmattus.certificatetransparency #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

pierrezimmermannbam
Copy link
Contributor

Fixes #15 by forcing vesion of com.appmattus.certificatetransparency:certificatetransparency-android to 2.5.0. A new version was released that was forcing kotlin 2.1.0 causing build issues for react native projects

Copy link
Contributor

@matthieugicquel matthieugicquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's release this to unblock builds, but we will have to look into how we can still get the CT data updates.

@matthieugicquel matthieugicquel changed the title Fix/android build expo fix: android builds failing because of incompatible kotlin version used by appmattus.certificatetransparency Jan 30, 2025
@matthieugicquel matthieugicquel merged commit c0c3c98 into main Jan 30, 2025
@matthieugicquel matthieugicquel deleted the fix/androidBuildExpo branch January 30, 2025 10:05
matthieugicquel added a commit that referenced this pull request Jan 30, 2025
matthieugicquel added a commit that referenced this pull request Jan 30, 2025
follow-up on #16

There's a low risk that outdated CT info breaks apps, but it makes them
a little less safe.

With this fix, automated updates from appmattus:certificatetransparency
will continue to come in for apps on RN >= 0.77 (or using kotlin 2), but
apps built with kotlin 1 will be stuck on the update from ~a week ago
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expo run:android fails
2 participants