Skip to content

fix(scaffolder-backend-module-annotator): fix backstage bump #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

imykhno
Copy link
Contributor

@imykhno imykhno commented Aug 12, 2025

Hey, I just made a Pull Request!

Update the createAnnotatorAction function to use the provided zod param for validation.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@imykhno imykhno requested review from debsmita1 and a team as code owners August 12, 2025 08:45
@imykhno imykhno requested review from BethGriggs and removed request for a team August 12, 2025 08:45
Copy link
Contributor

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imykhno I think it is also neeeded to update report.api.md.
You can update it by running:

yarn build:api-reports plugins/scaffolder-backend-module-annotator

@imykhno imykhno force-pushed the fix-scaffolder-backend-module-annotator/v1.41.1 branch from a674223 to 65c6012 Compare August 12, 2025 11:20
@imykhno imykhno force-pushed the fix-scaffolder-backend-module-annotator/v1.41.1 branch from 12e3461 to f5bbf36 Compare August 12, 2025 13:29
Signed-off-by: Ihor Mykhno <[email protected]>
@imykhno imykhno force-pushed the fix-scaffolder-backend-module-annotator/v1.41.1 branch from f5bbf36 to 28a1148 Compare August 12, 2025 13:48
@imykhno imykhno force-pushed the fix-scaffolder-backend-module-annotator/v1.41.1 branch from c9ebaa8 to 38870a1 Compare August 13, 2025 11:45
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@imykhno imykhno force-pushed the fix-scaffolder-backend-module-annotator/v1.41.1 branch from 38870a1 to b7a1f41 Compare August 15, 2025 15:00
@dzemanov dzemanov merged commit e0ac646 into backstage:scaffolder-backend-module-annotator/v1.41.1 Aug 18, 2025
10 checks passed
@imykhno imykhno deleted the fix-scaffolder-backend-module-annotator/v1.41.1 branch August 18, 2025 13:52
debsmita1 pushed a commit that referenced this pull request Aug 19, 2025
* v1.41.1 version bump

* fix(scaffolder-backend-module-annotator): fix backstage bump (#4914)

* fix: createAnnotatorAction method for the scaffolder-backend-module-annotator

Signed-off-by: Ihor Mykhno <[email protected]>

* docs: update the report.api.md

Signed-off-by: Ihor Mykhno <[email protected]>

* Update record zod schema

Signed-off-by: Ihor Mykhno <[email protected]>

* fix(scaffolder-backend-module-annotator): warnings in the `report.api.md`

Signed-off-by: Ihor Mykhno <[email protected]>

* fix(scaffolder-backend-module-annotator): schema for the `createAnnotatorAction` method

Signed-off-by: Ihor Mykhno <[email protected]>

---------

Signed-off-by: Ihor Mykhno <[email protected]>

---------

Signed-off-by: Ihor Mykhno <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ihor Mykhno <[email protected]>
lavanya-sainik-ericsson pushed a commit to lavanya-sainik-ericsson/community-plugins that referenced this pull request Aug 20, 2025
…age#4744)

* v1.41.1 version bump

* fix(scaffolder-backend-module-annotator): fix backstage bump (backstage#4914)

* fix: createAnnotatorAction method for the scaffolder-backend-module-annotator

Signed-off-by: Ihor Mykhno <[email protected]>

* docs: update the report.api.md

Signed-off-by: Ihor Mykhno <[email protected]>

* Update record zod schema

Signed-off-by: Ihor Mykhno <[email protected]>

* fix(scaffolder-backend-module-annotator): warnings in the `report.api.md`

Signed-off-by: Ihor Mykhno <[email protected]>

* fix(scaffolder-backend-module-annotator): schema for the `createAnnotatorAction` method

Signed-off-by: Ihor Mykhno <[email protected]>

---------

Signed-off-by: Ihor Mykhno <[email protected]>

---------

Signed-off-by: Ihor Mykhno <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ihor Mykhno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants