Skip to content

Update default non-dense behavior #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

Update default non-dense behavior #4877

merged 2 commits into from
Aug 18, 2025

Conversation

mbruhin
Copy link
Contributor

@mbruhin mbruhin commented Aug 8, 2025

Hey, I just made a Pull Request!

Updated the default behavior without dense specified to include the description:

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Update default non-dense behavior
fda5c46 
Signed-off-by: Matthew Bruhin <[email protected]>
@mbruhin mbruhin requested review from Xantier, punkle and a team as code owners August 8, 2025 17:35
@mbruhin mbruhin requested a review from awanlin August 8, 2025 17:35
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-tech-insights workspaces/tech-insights/plugins/tech-insights patch v0.6.1

@mbruhin
Copy link
Contributor Author

mbruhin commented Aug 8, 2025

fixes #4876

add API report
12807b8 
Signed-off-by: Matthew Bruhin <[email protected]>
awanlin
awanlin requested changes Aug 9, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mbruhin, can you add a before and after screen shot for these changes? Would help get a better idea of what this will look like and the impact.

awanlin
awanlin approved these changes Aug 9, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mbruhin, I had missed the linked issue #4876 which has images that helped me understand the change. This is good to me 🚀

Approving, but will leave it to the owners to merge.

@mbruhin
Copy link
Contributor Author

mbruhin commented Aug 18, 2025

@Xantier or @punkle would you be able to take a look at this when you have a moment?

Xantier
Xantier approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@Xantier Xantier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good! Thanks for the contribution 👍

@Xantier Xantier merged commit 43064bf into backstage:main Aug 18, 2025
11 checks passed
lavanya-sainik-ericsson pushed a commit to lavanya-sainik-ericsson/community-plugins that referenced this pull request Aug 20, 2025
@mbruhin @lavanya-sainik-ericsson
Update default non-dense behavior (backstage#4877)
16a71af 
* Update default non-dense behavior

Signed-off-by: Matthew Bruhin <[email protected]>

* add API report

Signed-off-by: Matthew Bruhin <[email protected]>

---------

Signed-off-by: Matthew Bruhin <[email protected]>
Co-authored-by: Matthew Bruhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xantier Xantier Xantier approved these changes

@awanlin awanlin awanlin approved these changes

@punkle punkle Awaiting requested review from punkle punkle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbruhin @Xantier @awanlin