Skip to content

Change React.PropTypes to just PropTypes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

brownieboy
Copy link
Contributor

Fix for issue #28, now that React.PropTypes no longer works in React 15.5 or higher. PropTypes have been moved to their own package.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your pr

@xtuc xtuc merged commit 17f0db5 into babel:master Feb 26, 2018
@brownieboy
Copy link
Contributor Author

Thanks for the merge.

So how do we get the changes onto https://packagecontrol.io/ ?

@xtuc
Copy link
Member

xtuc commented Feb 26, 2018

I'm new to this sorry, I think we need to do a git tag on this repo.

I can look into it tomorrow again.

@xtuc
Copy link
Member

xtuc commented Feb 27, 2018

I did a release https://github.com/babel/babel-sublime-snippets/releases/tag/v1.0.7. It will update anytime soon on packagecontrol, could you maybe try on your side?

@brownieboy
Copy link
Contributor Author

Cool. I'll keep a look out for that.

@brownieboy
Copy link
Contributor Author

And we have lift off!!

It now shows as 1.0.7 at https://packagecontrol.io/packages/Babel%20Snippets, and it updated in my own setup just now.

@xtuc
Copy link
Member

xtuc commented Feb 28, 2018

Cool, thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants