[Conditional Formatter] Use invariant decimal parsing #456
Merged
axunonb merged 2 commits intoaxuno:mainfrom Dec 18, 2024
Merged
[Conditional Formatter] Use invariant decimal parsing #456axunonb merged 2 commits intoaxuno:mainfrom
axunonb merged 2 commits intoaxuno:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
===================================
Coverage 97% 97%
===================================
Files 96 96
Lines 3434 3434
===================================
Hits 3317 3317
Misses 117 117 ☔ View full report in Codecov by Sentry. |
karljj1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bug one of our users flagged.
The
decimalwas being parsed using the current culture which could cause parsing issues.