exclude files from format #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dulmandakh
changed the title
Owner
|
Hello @dulmandakh, Thanks for this very useful pull request! Please ignore the failing checks. Before I merge it, could you please separate the changes related to file selection and those related to the dependencies in two different commits? |
axel-op
force-pushed
the
master
branch
2 times, most recently
from
e95a8d6 to
230e739
Compare
Co-authored-by: Tariq Yusuf <[email protected]> Co-authored-by: DanielF <[email protected]>
Co-authored-by: Tariq Yusuf <[email protected]> Co-authored-by: DanielF <[email protected]>
Co-authored-by: Tariq Yusuf <[email protected]> Co-authored-by: DanielF <[email protected]>
Owner
|
@danielferromeral I've merged your commits from https://github.com/dulmandakh/googlejavaformat-action/pull/1 into @dulmandakh's branch and edited them. I've renamed the I will now merge this PR. Thanks to both of you 😊 |
Owner
|
The changes have been published under the new - uses: axel-op/[email protected]The changes have also been integrated into the - uses: axel-op/googlejavaformat-action@v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to exclude files from format checking. For example, https://github.com/dulmandakh/buck/runs/3570342055 in need to exclude .idea and some other files.
Also removes node_modules, and compiles to single dist/index.js (optimized) file, see https://github.com/actions/javascript-action.
Fixes #14